Add the hash value of signer into subject organizationunits #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 23.61% 23.92% +0.31%
==========================================
Files 9 9
Lines 1207 1212 +5
==========================================
+ Hits 285 290 +5
Misses 905 905
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/assign @skeeey |
qiujian16
reviewed
Mar 14, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ea90f1a
into
open-cluster-management-io:main
9 checks passed
openshift-merge-bot bot
pushed a commit
to stolostron/cluster-proxy
that referenced
this pull request
Mar 20, 2024
* Remove codecov token in actions. (open-cluster-management-io#174) Signed-off-by: xuezhaojun <zxue@redhat.com> * Use k8s 1.29 client libs (open-cluster-management-io#175) Signed-off-by: Tamal Saha <tamal@appscode.com> * Fix the verify error of logger. (open-cluster-management-io#177) Signed-off-by: GitHub <noreply@github.com> * Upgrade chart version to 0.4.0. (open-cluster-management-io#178) Signed-off-by: GitHub <noreply@github.com> * Update workflows. (open-cluster-management-io#179) Signed-off-by: GitHub <noreply@github.com> * Simplify installer watchers (open-cluster-management-io#180) Signed-off-by: Tamal Saha <tamal@appscode.com> * Remove unused code (open-cluster-management-io#181) Signed-off-by: Tamal Saha <tamal@appscode.com> * Fix LB type proxy server setup in chart (open-cluster-management-io#182) Signed-off-by: Tamal Saha <tamal@appscode.com> * Use default rollingout strategy. (open-cluster-management-io#184) Signed-off-by: GitHub <noreply@github.com> * Add the hash value of signer into subject organizationunits (open-cluster-management-io#183) Signed-off-by: GitHub <noreply@github.com> * Change examples to md format to reduce dependences. (open-cluster-management-io#185) Signed-off-by: GitHub <noreply@github.com> * Update stolostronagent. Signed-off-by: GitHub <noreply@github.com> --------- Signed-off-by: xuezhaojun <zxue@redhat.com> Signed-off-by: Tamal Saha <tamal@appscode.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Tamal Saha <tamal@appscode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate PR: open-cluster-management-io/ocm#377