support install ns from addonDeploymentConfig #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jian Qiu <jqiu@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiujian16
force-pushed
the
install-ns
branch
5 times, most recently
from
d66b049
to
8739f88
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 23.51% 23.39% -0.13%
==========================================
Files 9 9
Lines 1012 1013 +1
==========================================
- Hits 238 237 -1
- Misses 757 758 +1
- Partials 17 18 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 7ca42b7
into
open-cluster-management-io:main
9 checks passed
qiujian16
added a commit
to qiujian16/cluster-proxy
that referenced
this pull request
May 21, 2024
…t-io#194) * Support install namespace and remove installAll Signed-off-by: Jian Qiu <jqiu@redhat.com> * Support addon install ns from addonDeploymentConfig Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>
openshift-merge-bot bot
pushed a commit
to stolostron/cluster-proxy
that referenced
this pull request
May 22, 2024
* Update codecov action version to 4.2.0. (open-cluster-management-io#188) Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Use codecov token. (open-cluster-management-io#190) Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Remove codecov token in env. (open-cluster-management-io#191) Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Change codecov key name. (open-cluster-management-io#192) Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * support install ns from addonDeploymentConfig (open-cluster-management-io#194) * Support install namespace and remove installAll Signed-off-by: Jian Qiu <jqiu@redhat.com> * Support addon install ns from addonDeploymentConfig Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com> * Allow customize default install namespace from flag (open-cluster-management-io#195) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Support install ns in stolstron cluster-proxy Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> Co-authored-by: xuezhao <zxue@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.