Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactiveMode in proxy. #328

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Mar 30, 2023

This allows users to interact with managed clusters without constructing a clusteradm command everytime.

~ clusteradm proxy kubectl --cluster=cluster1 --sa=test -i
Please enter the kubectl command and use "exit" to quit the interactive mode
kubectl> get nodes
NAME                     STATUS   ROLES                  AGE   VERSION
cluster1-control-plane   Ready    control-plane,master   51m   v1.21.1
kubectl> get pods
No resources found in default namespace.
kubectl> get serviceaccount
NAME      SECRETS   AGE
default   1         51m
kubectl> exit
Exit from interactive mode

@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@xuezhaojun xuezhaojun changed the title Add interactiveMode in proxy. WIP-Add interactiveMode in proxy. Mar 30, 2023
@xuezhaojun
Copy link
Member Author

The e2e-test is failing but should be solved in another PR.

@qiujian16
Copy link
Member

this looks awesome!

@xuezhaojun xuezhaojun changed the title WIP-Add interactiveMode in proxy. Add interactiveMode in proxy. Mar 31, 2023
Signed-off-by: xuezhaojun <zxue@redhat.com>
@xuezhaojun
Copy link
Member Author

@qiujian16 The e2e test is passed, PTAL. Thanks!

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 20827b4 into open-cluster-management-io:main Apr 3, 2023
@xuezhaojun xuezhaojun deleted the add-interactive-mode-proxy branch April 3, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants