Allow multiline templatization #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkutler
force-pushed
the
multiline-templates
branch
2 times, most recently
from
3d2457e
to
22908a5
Compare
mprahl
requested changes
Jan 19, 2023
willkutler
force-pushed
the
multiline-templates
branch
from
22908a5
to
aa3173b
Compare
|
@mprahl thanks for the review! added a comment in the type file and an extra check for status message in the test case |
willkutler
force-pushed
the
multiline-templates
branch
from
aa3173b
to
1bb53b3
Compare
mprahl
reviewed
Jan 20, 2023
Adds a new field, object-templates-raw, that allows users to paste in an object template. This makes multiline templates, like those using the range keyword, possible. It can be set instead of object-templates, but both cannot be set. ref: https://issues.redhat.com/browse/ACM-2739?filter=-1 Signed-off-by: Will Kutler <wkutler@redhat.com>
willkutler
force-pushed
the
multiline-templates
branch
from
1bb53b3
to
d3e1d0a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, willkutler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new field, object-templates-raw, that allows users to paste in an object template. This makes multiline templates, like those using the range keyword, possible. It can be set instead of object-templates, but both cannot be set.
ref: https://issues.redhat.com/browse/ACM-2739?filter=-1
Signed-off-by: Will Kutler wkutler@redhat.com