Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump policy generator to v1.12.4 #377

Conversation

dhaiducek
Copy link
Member

  • I have taken backward compatibility into consideration.

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dcce8c6) 53.78% compared to head (f9ce821) 54.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   53.78%   54.24%   +0.46%     
==========================================
  Files          71       71              
  Lines       14959    14959              
==========================================
+ Hits         8046     8115      +69     
+ Misses       6091     6014      -77     
- Partials      822      830       +8     
Flag Coverage Δ
unit 54.24% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8b5df27 into open-cluster-management-io:main Dec 18, 2023
9 checks passed
@dhaiducek dhaiducek deleted the update-generator branch December 18, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants