Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about Submariner #3

Merged
merged 1 commit into from Oct 20, 2021
Merged

Add information about Submariner #3

merged 1 commit into from Oct 20, 2021

Conversation

nyechiel
Copy link
Contributor

Signed-off-by: nyechiel nyechiel@redhat.com

@nyechiel
Add information about Submariner
c18ae9b 
Signed-off-by: nyechiel <nyechiel@redhat.com>
@nyechiel
Copy link
Contributor Author

/assign qiujian16

qiujian16
qiujian16 reviewed Oct 19, 2021
View reviewed changes
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. @nyechiel . Are you ok if we have a separate section Integration or External Addons, and we can put submariner there? So we can also add other integrations later.

@nyechiel
Copy link
Contributor Author

thanks. @nyechiel . Are you ok if we have a separate section Integration or External Addons, and we can put submariner there? So we can also add other integrations later.

Fine with me. From our Slack conversation it sounded like Submariner is the only one worth mentioning at this point, but we can set the ground for others. Are you going to implement this change?

@qiujian16
Copy link
Member

yeah, I will do that.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nyechiel, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 87b0c75 into open-cluster-management-io:main Oct 20, 2021
xuezhaojun referenced this pull request in xuezhaojun/OCM Mar 21, 2023
@openshift-merge-robot
Merge pull request #3 from elgnay/add-missing-files
583e761 
add missing files
zhujian7 pushed a commit to zhujian7/ocm that referenced this pull request Oct 18, 2023
@Kyl-Bempah
Merge pull request open-cluster-management-io#3 from stolostron/appst…
ca494a3 
…udio-addon-manager

Red Hat Trusted App Pipeline update addon-manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiujian16 qiujian16 qiujian16 left review comments

@deads2k deads2k Awaiting requested review from deads2k

@jnpacker jnpacker Awaiting requested review from jnpacker

Assignees

@qiujian16 qiujian16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyechiel @qiujian16 @openshift-merge-robot