Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP 🐛 Fix: make kube a default value of workloadsourcedriver. #375

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Mar 12, 2024

Summary

We want use kube as the default driver even no driver set.

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuezhaojun
Once this PR has been reviewed and has the lgtm label, please assign zhujian7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.37%. Comparing base (b4bf3d0) to head (99b1f1a).
Report is 45 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   61.37%   61.37%           
=======================================
  Files         132      132           
  Lines       14051    14051           
=======================================
  Hits         8624     8624           
  Misses       4672     4672           
  Partials      755      755           
Flag Coverage Δ
unit 61.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun xuezhaojun force-pushed the fix-make-kube-as-the-default-value-of-WorkloadSourceDriver branch from fad06ac to 7791d11 Compare March 12, 2024 15:56
@@ -28,6 +30,7 @@ func NewWorkloadAgentOptions() *WorkloadAgentOptions {
MaxJSONRawLength: 1024,
StatusSyncInterval: 10 * time.Second,
AppliedManifestWorkEvictionGracePeriod: 60 * time.Minute,
WorkloadSourceDriver: work.ConfigTypeKube,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to default the kubcoonfig file path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, added.

Signed-off-by: GitHub <noreply@github.com>
@xuezhaojun xuezhaojun force-pushed the fix-make-kube-as-the-default-value-of-WorkloadSourceDriver branch from 7791d11 to 99b1f1a Compare March 12, 2024 16:27
@xuezhaojun xuezhaojun changed the title 🐛 Fix: make kube a default value of workloadsourcedriver. WIP 🐛 Fix: make kube a default value of workloadsourcedriver. Mar 13, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xuezhaojun
Copy link
Member Author

Fixed by another PR, close
/close

Copy link
Contributor

openshift-ci bot commented Apr 28, 2024

@xuezhaojun: Closed this PR.

In response to this:

Fixed by another PR, close
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants