Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ upgrade sdk to support Kafka #433

Closed
wants to merge 1 commit into from

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented Apr 19, 2024

Summary

Related issue(s)

Fixes #

Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skeeey
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skeeey
Copy link
Member Author

skeeey commented Apr 19, 2024

/hold

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.40%. Comparing base (bcbe4d2) to head (ae17bd9).
Report is 24 commits behind head on main.

❗ Current head ae17bd9 differs from pull request most recent head 5fba890. Consider uploading reports for the commit 5fba890 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   61.54%   62.40%   +0.85%     
==========================================
  Files         133      133              
  Lines       14078    11333    -2745     
==========================================
- Hits         8665     7072    -1593     
+ Misses       4664     3507    -1157     
- Partials      749      754       +5     
Flag Coverage Δ
unit 62.40% <ø> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Wei Liu <liuweixa@redhat.com>
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants