Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ upgrade sdk to support Kafka as a cloudevents driver #436

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented Apr 22, 2024

Summary

Related issue(s)

Fixes #

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.51%. Comparing base (bcbe4d2) to head (6d46452).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   61.54%   62.51%   +0.96%     
==========================================
  Files         133      134       +1     
  Lines       14078    11430    -2648     
==========================================
- Hits         8665     7146    -1519     
+ Misses       4664     3521    -1143     
- Partials      749      763      +14     
Flag Coverage Δ
unit 62.51% <ø> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skeeey skeeey force-pushed the kk-2 branch 5 times, most recently from 0bea553 to 559c375 Compare April 23, 2024 02:07
@skeeey
Copy link
Member Author

skeeey commented Apr 23, 2024

/assign @qiujian16

@skeeey
Copy link
Member Author

skeeey commented Apr 23, 2024

/hold

Signed-off-by: Wei Liu <liuweixa@redhat.com>
@skeeey
Copy link
Member Author

skeeey commented Apr 25, 2024

/unhold

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 25, 2024
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0882f6d into open-cluster-management-io:main Apr 25, 2024
15 checks passed
skeeey added a commit to skeeey/ocm that referenced this pull request Apr 26, 2024
skeeey added a commit to skeeey/ocm that referenced this pull request Apr 26, 2024
openshift-merge-bot bot pushed a commit that referenced this pull request Apr 26, 2024
Signed-off-by: Wei Liu <liuweixa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants