Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Refresh external managed token secret if service account ns changes #458

Merged

Conversation

zhujian7
Copy link
Member

Summary

Related issue(s)

Fixes #

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 62.62%. Comparing base (e4202dd) to head (5ea82ae).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/operator/helpers/sa_syncer.go 53.57% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   62.58%   62.62%   +0.03%     
==========================================
  Files         136      136              
  Lines       11504    11529      +25     
==========================================
+ Hits         7200     7220      +20     
- Misses       3536     3540       +4     
- Partials      768      769       +1     
Flag Coverage Δ
unit 62.62% <53.57%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7
Copy link
Member Author

/cc @qiujian16 @xuezhaojun

@openshift-ci openshift-ci bot requested a review from qiujian16 May 13, 2024 09:26
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhujian7
Copy link
Member Author

/cc @elgnay

@openshift-ci openshift-ci bot requested a review from elgnay May 14, 2024 02:50
@elgnay
Copy link
Contributor

elgnay commented May 14, 2024

/lgtm
/hold Hold in case someone else wants to take a look.

@xuezhaojun
Copy link
Member

/lgtm

@qiujian16
Copy link
Member

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 5313ff7 into open-cluster-management-io:main May 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants