Add Emu2 and Emu2_chat #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlmeval/config.py
Outdated
| @@ -17,6 +17,11 @@ | |||
| 'llava_v1_7b': 'Please set your local path to LLaVA-7B-v1.1 here, the model weight is obtained by merging LLaVA delta weight based on vicuna-7b-v1.1 in https://github.com/haotian-liu/LLaVA/blob/main/docs/MODEL_ZOO.md with vicuna-7b-v1.1. ' | |||
| } | |||
|
|
|||
| emu_model_path_map={ | |||
There was a problem hiding this comment.
You can remove this and place the model_map in emu.py, no need to add a model_path_map arg.
vlmeval/config.py
Outdated
| @@ -43,6 +48,8 @@ | |||
| 'cogvlm-grounding-generalist':partial(CogVlm, name='cogvlm-grounding-generalist',tokenizer_name ='lmsys/vicuna-7b-v1.5'), | |||
| 'cogvlm-chat':partial(CogVlm, name='cogvlm-chat',tokenizer_name ='lmsys/vicuna-7b-v1.5'), | |||
| 'sharedcaptioner':partial(SharedCaptioner, model_path='Lin-Chen/ShareCaptioner'), | |||
| 'emu2':partial(Emu, name='emu2', model_path_map=emu_model_path_map), | |||
| 'emu_chat':partial(Emu, name='emu_chat', model_path_map=emu_model_path_map), | |||
vlmeval/vlm/emu.py
Outdated
| self.kwargs = {'max_length': 128} | ||
|
|
||
|
|
||
| def generate(self, image_path, prompt, dataset=None): |
There was a problem hiding this comment.
You can use interleave_generate to implement generate, seems they can be formulates to the same form.
vlmeval/vlm/emu.py
Outdated
| low_cpu_mem_usage=True, | ||
| trust_remote_code=True).to(device).eval() | ||
| self.model = model | ||
| self.kwargs = {'max_length': 128} |
There was a problem hiding this comment.
Do you mean max_new_tokens? This arg is not used during generation.
By the way, use can pass generation kwargs via **kwargs in __init__, so remember to add them. Besides, remember to use self.kwargs during generation.
kennymckormick
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.