Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sample count in prompt_viewer #273

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

cdpath
Copy link
Contributor

@cdpath cdpath commented Aug 25, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add support to print multi samples from dataset

Modification

Add a for loop to extract multiple prompts

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@cdpath
Copy link
Contributor Author

cdpath commented Aug 25, 2023

Also, I'd like to add a subcommand to dump prompts to unified dataset format (jsonl, for example).

@gaotongxiao
Copy link
Collaborator

Also, I'd like to add a subcommand to dump prompts to unified dataset format (jsonl, for example).

Sounds cool!

@Leymore Leymore merged commit fa7978f into open-compass:main Aug 29, 2023
1 check passed
go-with-me000 pushed a commit to go-with-me000/opencompass that referenced this pull request Oct 9, 2023
* support sample count in prompt_viewer

* update

---------

Co-authored-by: Leymore <zfz-960727@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants