[Sync] [Enhancement] Simplify execution logic in run.py; use finally to clean up temp files #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leymore
approved these changes
Sep 4, 2023
fangyixiao18
approved these changes
Sep 4, 2023
go-with-me000
pushed a commit
to go-with-me000/opencompass
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The former logic in run.py is rather complex when user chooses to specify task parameters from CLI instead of config - it uses "exec_xxx_runner" and makes the entire execution flow diverge from the configuration path. Such an implementation makes it hard for future maintenance and leads to unnecessary code redundancies.
This PR unifies the execution flow and now all the parameter specifications are performed through the modifications on the configuration object.
Besides, this PR uses
try... finally...to make sure temporary files created during running can be cleaned even when an exception has been raised (e.g. KeyBoardInterrupt).