Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMB #376

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Add CMB #376

merged 2 commits into from
Sep 12, 2023

Conversation

wangxidong06
Copy link
Contributor

Motivation
Add CMB dataset.

Modification
Add /opencompass/opencompass/datasets/cmb.py
Modify /opencompass/opencompass/models/init.py
Add /opencompass/configs/datasets/cmb
Add /opencompass/data/CMB/test.json and /opencompass/data/CMB/val.json

configs/datasets/cmb/cmb_ppl_74ec55.py Outdated Show resolved Hide resolved
opencompass/datasets/cmb.py Show resolved Hide resolved
@Leymore
Copy link
Collaborator

Leymore commented Sep 11, 2023

Thank you very much for your contribution. CMB is indeed a nice work. We're very sorry that we messed up the hash suffix of BBH last week, which resulted in us reopening an issue. Our apologies again.

I've noticed that your modifications involve the /opencompass/data/CMB/test.json and /opencompass/data/CMB/val.json files. However, these two files are added to the .gitignore and won't be pushed. Also, I noticed that this file doesn't exist on https://github.com/FreedomIntelligence/CMB. Therefore, you might want to consider sharing this file with us through other means, such as directly uploading it to the pull request, and then we can add this dataset to our releases.

Additionally, the meaning of PPL is to calculate the perplexity of different data prompt sentences. Given that there are multiple correct options in the CMB dataset, I'm not sure if a PPL evaluation would be feasible? If it's not feasible, you can directly delete the implementation of PPL. Otherwise, you might consider using PPL for single correct options and Gen for multiple correct options. You can refer to the following implementation:

https://github.com/open-compass/opencompass/blob/63ced828d86dcda4d11258f02492edc18c80aaa9/configs/datasets/agieval/agieval_mixed_2f14ad.py

@Leymore Leymore assigned Leymore and unassigned tonysy Sep 11, 2023
@wangxidong06
Copy link
Contributor Author

Thanks for your kindly advice. I remove the implementation of PPL and share the specific data to @gaotongxiao.

@gaotongxiao gaotongxiao merged commit 47a752c into open-compass:main Sep 12, 2023
3 checks passed
@gaotongxiao
Copy link
Collaborator

Thanks for your contribution!

@amulil
Copy link

amulil commented Sep 14, 2023

@gaotongxiao @Leymore

FileNotFoundError: [Errno 2] No such file or directory: './data/CMB/test.json'

where I can download the test.json, I git pull the lastest code and download data from  https://github.com/FreedomIntelligence/CMB, there is no test.json file.

go-with-me000 pushed a commit to go-with-me000/opencompass that referenced this pull request Oct 9, 2023
* Add CMB

* modify CMB

---------

Co-authored-by: wangxidong <xidongw@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants