Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential OOM issue #387

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix potential OOM issue #387

merged 1 commit into from
Sep 12, 2023

Conversation

cdpath
Copy link
Contributor

@cdpath cdpath commented Sep 11, 2023

Motivation

Fix OOM while using MDLRetriever

Modification

wrap critical func with torch.no_grad

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Leymore Leymore merged commit 722eb39 into open-compass:main Sep 12, 2023
3 checks passed
go-with-me000 pushed a commit to go-with-me000/opencompass that referenced this pull request Oct 9, 2023
@cdpath cdpath deleted the fix_oom branch October 17, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants