[SIG] add WikiText-2&103 #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingfhu
reviewed
Sep 15, 2023
KevinNuNu
force-pushed
the
add_wikitext_dataset
branch
from
7dad1ff
to
1f21fef
Compare
yingfhu
reviewed
Sep 26, 2023
| @@ -0,0 +1,4 @@ | |||
| from mmengine.config import read_base | |||
There was a problem hiding this comment.
the file name should be gen but not ppl
yingfhu
reviewed
Sep 26, 2023
Comment on lines
+8
to
+15
| wikitext_infer_cfg = dict( | ||
| prompt_template=dict( | ||
| type=PromptTemplate, | ||
| template={0: '{text}'} | ||
| ), | ||
| retriever=dict(type=ZeroRetriever), | ||
| inferencer=dict(type=GenInferencer), # need a new ppl inferencer | ||
| ) |
There was a problem hiding this comment.
The template is ppl format but the inferencer is gen, any explanation about this?
There was a problem hiding this comment.
this dataset is different need a new PPLInferencer
so gaotongxiao suggests using GenInferencer instead
There was a problem hiding this comment.
got it, and please rebase the main branch to fix the conflict
There was a problem hiding this comment.
got it, and please rebase the main branch to fix the conflict
done~
KevinNuNu
force-pushed
the
add_wikitext_dataset
branch
from
1f21fef
to
ea30863
Compare
go-with-me000
pushed a commit
to go-with-me000/opencompass
that referenced
this pull request
Oct 9, 2023
* fix conflict * add eval_cfg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Add text generation dataset WikiText.
Need to add a new PPLInferencer.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: