Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom summarizer argument in CLI run mode 在CLI启动模式中添加自定义Summarizer参数 #411

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

so2liu
Copy link
Contributor

@so2liu so2liu commented Sep 18, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The new CLI mode is very helpful. But it's lack of custom summarizer argument. This PR solves this. User can use python run.py --models hf_qwen_7b --datasets smoking_gen --summarizer configs/summarizers/medium.py to run with custom summarizer.

Modification

  1. Add --summarizer argument
  2. read related config file
  3. fix related bug to compatible with command without custom summarizer

Use cases

The following cases are tested. smoking_gen is a short custom defined dataset to test quickly.

  • python run.py --models hf_qwen_7b --datasets smoking_gen --summarizer configs/summarizers/medium.py
  • python run.py --models hf_qwen_7b --datasets smoking_gen

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@gaotongxiao gaotongxiao merged commit 267401b into open-compass:main Sep 18, 2023
2 of 3 checks passed
@gaotongxiao
Copy link
Collaborator

Thanks!

go-with-me000 pushed a commit to go-with-me000/opencompass that referenced this pull request Oct 9, 2023
…er参数 (open-compass#411)

* feat: add custom summarizer in CLI run mode

* feat: search local config by match_cfg_file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants