support customize config path #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaotongxiao
reviewed
Sep 21, 2023
run.py
Outdated
| @@ -82,6 +82,11 @@ def parse_args(): | |||
| './outputs/default.', | |||
| default=None, | |||
| type=str) | |||
| parser.add_argument('--custom-config-dir', | |||
There was a problem hiding this comment.
Suggested change
| parser.add_argument('--custom-config-dir', | |
| parser.add_argument('--config-dir', default='configs', |
In this way the parameter name can be shorter and more concise.
opencompass/utils/run.py
Outdated
| @@ -60,7 +60,8 @@ def get_config_from_arg(args) -> Config: | |||
| raise ValueError('You must specify "--datasets" if you do not specify ' | |||
| 'a config file path.') | |||
| datasets = [] | |||
| for dataset in match_cfg_file('configs/datasets/', args.datasets): | |||
| config_base_dir = args.custom_config_dir or 'configs' | |||
| for dataset in match_cfg_file(f'{config_base_dir}/datasets/', args.datasets): | |||
There was a problem hiding this comment.
Using os.path.join is better than string-style concatenation.
chenbohua3
force-pushed
the
support_custom_folder
branch
from
c5f613f
to
82fe829
Compare
go-with-me000
pushed a commit
to go-with-me000/opencompass
that referenced
this pull request
Oct 9, 2023
* support customize config path * support customize config path * support customize config path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the config path can be customized, then when other projects introduce opencompass, they can maintain their own datasets/models configuration in their own projects:)