[Refactor] Move fix_id_list to Retriever #442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The prior design that decoupled
fix_id_list
fromFixKRetriever
was terrible and resulted in code redundancy in Inferencers. It also hampered the development of some incoming features.BC-breaking
This PR breaks some custom config where
FixKRetriever
is used, but the effect may not be significant, and the migration cost is acceptable. Specifically, users would need to change their configs fromto
Which is quite straightforward.