[Fix] Use jieba rouge in lcsts #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaotongxiao
approved these changes
Oct 9, 2023
2 tasks
liushz
pushed a commit
to liushz/opencompass
that referenced
this pull request
Nov 27, 2023
* use jieba rouge in lcsts * use rouge_chinese
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original rouge implementation used the one from huggingface, which could not handle Chinese datasets, such as LCSTS, correctly and would output 0. In the LCSTS dataset, there were English words and numbers. The huggingface rouge calculation would ignore all Chinese characters and only consider English words and numbers for scoring.
Now, we have switched to using jieba for tokenization and adopted the implementation from https://github.com/pltrdy/rouge, which can correctly process Chinese.