Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] support download from modelscope #534

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

KevinNuNu
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

根据opencompass/models/huggingface.py复制修改成opencompass/models/modelscope.py

目前简单写了两个config作为验证功能是ok的
(1) configs/models/ms_internlm/ms_internlm_chat_7b_8k.py
(2) configs/models/qwen/ms_qwen_7b_chat.py

TODO:

  1. modelscope.py与huggingface.py代码复用率很高,更优雅的方式希望讨论交流下
  2. 目前configs/models下internlm模型有两个文件夹internlm和hf_internlm,如果增加了modelscope的下载方式,是否重新规范一下目录文件夹命名?

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@yingfhu
Copy link
Contributor

yingfhu commented Nov 22, 2023

Remove duplicated code, not all model in modelscope is supported, only those identical with HF can be correctly loaded.
People use this example should be careful.

@yingfhu yingfhu merged commit c0785e5 into open-compass:main Nov 22, 2023
4 checks passed
@KevinNuNu KevinNuNu deleted the add_models_modelscope branch November 26, 2023 07:56
liushz pushed a commit to liushz/opencompass that referenced this pull request Nov 27, 2023
* [Feature] download from modelscope

* [Feature] download from modelscope

* minor fix

---------

Co-authored-by: yingfhu <yingfhu@gmail.com>
liuyaox pushed a commit to liuyaox/opencompass that referenced this pull request Jun 26, 2024
* [Feature] download from modelscope

* [Feature] download from modelscope

* minor fix

---------

Co-authored-by: yingfhu <yingfhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants