[Feature] Add circular eval #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingfhu
reviewed
Nov 22, 2023
opencompass/datasets/circular.py
Outdated
| return circular_patterns | ||
|
|
||
|
|
||
| class CircularMixIN: |
There was a problem hiding this comment.
The CircularMixIN seems unnecessary here since it does not mix with any classes and all the method is static.
- if use class, does circular_patterns, option_keys etc. can be set as class attribute? The inputs of each func seems redundant
- or can we just use function here?
yingfhu
reviewed
Nov 22, 2023
opencompass/summarizers/default.py
Outdated
There was a problem hiding this comment.
BTW, will this modification break other summerizers?
Leymore
force-pushed
the
add-circular
branch
from
153d820
to
3ebfe0c
Compare
liushz
pushed a commit
to liushz/opencompass
that referenced
this pull request
Nov 27, 2023
* refactor default, add circular summarizer * add circular * update impl * update doc * minor update * no more to be added
liuyaox
pushed a commit
to liuyaox/opencompass
that referenced
this pull request
Jun 26, 2024
* refactor default, add circular summarizer * add circular * update impl * update doc * minor update * no more to be added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.