Fix ocm issue 179, block in config yields invalid yaml #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dee0sap
changed the title
|
@mandelsoft , can you please takle a look at this proposal? |
Skarlso
force-pushed
the
ocm-issue-179-block-in-config-yields-invalid-xml
branch
from
819ebf5
to
527d458
Compare
|
@dee0sap All you have to do is indent the value that you wish to substitute correctly. We marshal values before doing anything this PR now fixes that in the sense that we don't marshal primitive values. That marshalling broke the syntax of the value that we are trying to insert. So we leave values alone. But we do marshal complex types like struct, pointer, maps, etc. |
Skarlso
changed the title
- Reduce test fragility by using MatchYAML and MatchJSON instead of checking for string equality which breaks with minor white space changes - Remove unused Set function which exposes implementation detail of goccy usage
…-model#179. Confirmed that pre-yqlib the test fails and that after yqlib it passes.
…toring a non-string value
…e substitution data is converted to yaml format
dee0sap
changed the title
|
I think this PR is ready for whatever review process you guys have. |
Skarlso
reviewed
May 2, 2024
Skarlso
reviewed
May 2, 2024
Skarlso
reviewed
May 2, 2024
Skarlso
reviewed
May 2, 2024
|
If anything breaks because of this, we'll iterate on a solution. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes open-component-model/ocm-project#179
What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: