feat(condo): DOMA-8429 added user import help request #4513
Conversation
nomerdvadcatpyat
added
✋🙂 Review please
nomerdvadcatpyat
force-pushed
the
feat/condo/DOMA-8429/added-user-import-help-request
branch
from
928c80b
to
27f5edf
Compare
| const files = await UserHelpRequestFile.getAll(context, { userHelpRequest: { id: userHelpRequestId } }) | ||
|
|
||
| if (!isEmpty(files)) { | ||
| const currentMeta = { ...get(existingItem, fieldPath, {}), ...get(resolvedData, fieldPath, {}) } |
There was a problem hiding this comment.
Should we merge old data with new?
There was a problem hiding this comment.
It turns out like this:
- If there are files, then save only the new data
- If there are no files, then save both old and new data
Why does the behavior differ?
There was a problem hiding this comment.
User can not disconnect file after he create UserHelpRequest.
There will be no case where a file related to a help request will be deleted
| hooks: { | ||
| afterChange: fileMetaAfterChange, | ||
| }, |
There was a problem hiding this comment.
Should we update UserHelpRequest.meta after deleting the connected file?
There was a problem hiding this comment.
I think no, user can not update UserHelpRequestFile if it's linked with UserHelpRequest
| } | ||
| </Upload> | ||
| </div> | ||
| <StyledUpload {...options}> |
There was a problem hiding this comment.
why not className='upload-control-wrapper'?
nomerdvadcatpyat
force-pushed
the
feat/condo/DOMA-8429/added-user-import-help-request
branch
3 times, most recently
from
11ee6b3
to
521b391
Compare
nomerdvadcatpyat
force-pushed
the
feat/condo/DOMA-8429/added-user-import-help-request
branch
from
7f49148
to
70cca59
Compare
|
nomerdvadcatpyat
deleted the
feat/condo/DOMA-8429/added-user-import-help-request
branch
After the user requests help with the import,
UserHelpRequestwill be created and sent to managers via webhooks