feat(dev-portal): INFRA-243 stricter icon requirements #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SavelevMatthew
added
👶 small
Alllex202
approved these changes
Mar 27, 2024
toplenboren
approved these changes
Mar 27, 2024
|
It is best to provide templates for icon too. In png / svg format. So they can easily import it to their editing tool |
I don't think so, 1mb is more than enough for any png in specified size and this limits are flexible. Size and color limits are strict, so we need to specify it explicitly |
|
Ty for awesome advice. Added a link to our style guides 👍 |
SavelevMatthew
deleted the
feat/dev-portal/INFRA-243/picture-restrictions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Screen.Recording.2024-03-27.at.16.06.34.mov