New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(condo): DOMA-8653 fixed table filters #4539
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The videos does not show any positive improvements. Does really useMemo works here as a solution?
@@ -134,7 +134,7 @@ export const Table: React.FC<ITableProps> = ({ | |||
const newParameters = getFiltersQueryData(newFilters, newSorters, newOffset) | |||
return updateQuery(router, { newParameters }, { resetOldParameters: false }) | |||
} | |||
}, 400) | |||
}, 400), [applyQuery, filters, router, rowsPerPage, sorters]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At inputs we use DEBOUNCE_TIMEOUT = 800 value. So maybe provide that change here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The search on the page uses the value 400, so I'll leave it as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really 800? 🙃 looks like this needs to be fixed
Yup, but maybe not in this PR)
The first video shows that the characters are erased during printing. There is no such behavior in the second video. |
Oh, now I see what happend. For that reason that might be a solution |
Before
2024-03-28.17.43.04.mov
After
2024-03-28.17.43.48.mov