Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(condo): DOMA-8653 fixed table filters #4539

Merged
merged 1 commit into from Mar 28, 2024

Conversation

Alllex202
Copy link
Contributor

Before

2024-03-28.17.43.04.mov

After

2024-03-28.17.43.48.mov

@Alllex202 Alllex202 added 👶 small Easy to review changes up to 50 lines of code ✋🙂 Review please Comments are resolved, take a look, please labels Mar 28, 2024
Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@sitozzz sitozzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The videos does not show any positive improvements. Does really useMemo works here as a solution?

@@ -134,7 +134,7 @@ export const Table: React.FC<ITableProps> = ({
const newParameters = getFiltersQueryData(newFilters, newSorters, newOffset)
return updateQuery(router, { newParameters }, { resetOldParameters: false })
}
}, 400)
}, 400), [applyQuery, filters, router, rowsPerPage, sorters])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At inputs we use DEBOUNCE_TIMEOUT = 800 value. So maybe provide that change here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really 800? 🙃
looks like this needs to be fixed
Снимок экрана 2024-03-28 в 17 56 53

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search on the page uses the value 400, so I'll leave it as is

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really 800? 🙃 looks like this needs to be fixed
Yup, but maybe not in this PR)

@Alllex202
Copy link
Contributor Author

The videos does not show any positive improvements. Does really useMemo works here as a solution?

The first video shows that the characters are erased during printing. There is no such behavior in the second video.

@sitozzz
Copy link
Member

sitozzz commented Mar 28, 2024

The videos does not show any positive improvements. Does really useMemo works here as a solution?

The first video shows that the characters are erased during printing. There is no such behavior in the second video.

Oh, now I see what happend. For that reason that might be a solution

@Alllex202 Alllex202 merged commit 319ad34 into master Mar 28, 2024
26 checks passed
@Alllex202 Alllex202 deleted the fix/condo/DOMA-8653/fix-filters branch March 28, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋🙂 Review please Comments are resolved, take a look, please 👶 small Easy to review changes up to 50 lines of code
Development

Successfully merging this pull request may close these issues.

None yet

3 participants