Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(condo): DOMA-8650 fixed case when address was not resolved correctly #4548

Conversation

dkoviazin
Copy link
Contributor

  1. Fixed find organization properties query in account resolver
  2. Some times globalId was saved with unit in property
  3. If dadata returns the correct value not in first place of array - wrong address was registered

@dkoviazin dkoviazin added 👶 small Easy to review changes up to 50 lines of code 🔥 HOTFIX We need to merge it ASAP ✋🙂 Review please Comments are resolved, take a look, please labels Mar 30, 2024
Copy link

sonarcloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dkoviazin dkoviazin merged commit 6ac1b96 into master Apr 1, 2024
23 checks passed
@dkoviazin dkoviazin deleted the fix/condo/DOMA-8650/use_address_key_resolved_instead_of_address branch April 1, 2024 12:36
nomerdvadcatpyat pushed a commit that referenced this pull request Apr 2, 2024
…tly (#4548)

* fix(condo): DOMA-8650 fixed case when address was not resolved correctly

* fix(DOMA-8650): fixed tests

* fix(condo): DOMA-8650 review fixes

* fix(condo): DOMA-8650 review fixes
nomerdvadcatpyat pushed a commit that referenced this pull request Apr 2, 2024
…tly (#4548)

* fix(condo): DOMA-8650 fixed case when address was not resolved correctly

* fix(DOMA-8650): fixed tests

* fix(condo): DOMA-8650 review fixes

* fix(condo): DOMA-8650 review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 HOTFIX We need to merge it ASAP ✋🙂 Review please Comments are resolved, take a look, please 👶 small Easy to review changes up to 50 lines of code
Development

Successfully merging this pull request may close these issues.

None yet

3 participants