feat(global): INFRA-298 remove virtual fields from history records #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomerdvadcatpyat
approved these changes
Apr 5, 2024
sitozzz
reviewed
Apr 5, 2024
|
|
||
| exports.up = async (knex) => { | ||
| await knex.raw(` | ||
| BEGIN; |
There was a problem hiding this comment.
Maybe add a statement timeout here? That's a lot of data to remove
There was a problem hiding this comment.
@reactpro said, that its ok, since drop column = mark at as hidden. So it's fast. And then garbage collector clears it in background
SavelevMatthew
force-pushed
the
feat/global/INFRA-298/virtual-history
branch
from
bfa8582
to
2417836
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.