Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(condo: DOMA-8777): fixed incidents with deleted property #4590

Merged

Conversation

Alllex202
Copy link
Contributor

Before

Editing:

  • Problems with deleted properties
  • No button to cancel editing
Снимок экрана 2024-04-09 в 14 34 05

Table:

  • undefined is displayed instead of deleted property address
Снимок экрана 2024-04-09 в 14 33 34

Incident view page by id

  • page crashes

After

  • Added button to cancel editing
  • Deleted properties are displayed correctly
  • Incident view page does not crash
2024-04-09.14.36.29.mov

@Alllex202 Alllex202 added the ✋🙂 Review please Comments are resolved, take a look, please label Apr 9, 2024
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Alllex202 Alllex202 merged commit a71ea25 into master Apr 10, 2024
24 of 25 checks passed
@Alllex202 Alllex202 deleted the fix/condo/DOMA-8777/fix-incident-with-deleted-property branch April 10, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋🙂 Review please Comments are resolved, take a look, please
Development

Successfully merging this pull request may close these issues.

None yet

3 participants