feat(condo): INFRA-300 Message prioritization 📧📈 #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SavelevMatthew
added
👶 small
sitozzz
reviewed
Apr 9, 2024
sitozzz
reviewed
Apr 9, 2024
sitozzz
reviewed
Apr 9, 2024
| * @returns {'medium' | 'high' | 'low'} condo task queue | ||
| */ | ||
| function getMessageQueue ({ type }) { | ||
| // TODO(VKislov): separate queue for VoIP here? |
AleX83Xpert
reviewed
Apr 9, 2024
SavelevMatthew
force-pushed
the
feat/condo/INFRA-300/send-message-priority
branch
from
f7a9a05
to
faac6d6
Compare
AleX83Xpert
reviewed
Apr 9, 2024
...migrations/20240409162533-0380_alter_message_type_alter_messageappblacklist_type_and_more.js
Outdated
Show resolved
Hide resolved
Because of how this mechanism works under the hood. In short, this is due to the fact that priority in the queue only works with redis. Also that's really expensive operation for redis instance. |
SavelevMatthew
force-pushed
the
feat/condo/INFRA-300/send-message-priority
branch
from
911ad5a
to
7b31e2d
Compare
AleX83Xpert
approved these changes
Apr 11, 2024
| @@ -100,7 +100,9 @@ function removeCronTask (name, cron, opts = {}) { | |||
| REMOVE_CRON_TASKS.push([name, taskOpts]) | |||
| } | |||
|
|
|||
| async function _scheduleRemoteTask (name, preparedArgs, preparedOpts, queue = DEFAULT_QUEUE_NAME) { | |||
| async function _scheduleRemoteTask (name, preparedArgs, preparedOpts, queueName = DEFAULT_QUEUE_NAME) { | |||
| const queue = TASK_QUEUE_REMAPPING.hasOwnProperty(queueName) ? TASK_QUEUE_REMAPPING[queueName] : queueName | |||
There was a problem hiding this comment.
Suggested change
| const queue = TASK_QUEUE_REMAPPING.hasOwnProperty(queueName) ? TASK_QUEUE_REMAPPING[queueName] : queueName | |
| const queue = get(TASK_QUEUE_REMAPPING, queueName, queueName) |
SavelevMatthew
force-pushed
the
feat/condo/INFRA-300/send-message-priority
branch
from
f154da5
to
5fea60a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.