Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(condo): DOMA-8789 fixed news items recipients loading #4605

Merged

Conversation

Alllex202
Copy link
Contributor

@Alllex202 Alllex202 commented Apr 11, 2024

Before

  • No news sending status
  • News recipients take a long time to load
  • No loading indicator
  • Repeated requests for counters are sent every time
2024-04-11.20.01.36.mov
  • No adaptive layout
2024-04-11.20.02.31.mov

Also:

  • The getNewsItemsRecipientsCounters query could return a timeout during a complex query to the database

After

  • Added news sending status (as in table)
  • Recipients load quickly
  • Counters still take a long time to load, but with a loading indicator
  • Repeated requests for counters are retrieved from the cache
2024-04-11.19.56.04.mov
  • Added adaptive layout
2024-04-11.19.57.50.mov

Also:

  • Reduced chunks size for requests in the getNewsItemsRecipientsCounters query

@Alllex202 Alllex202 added the ✋🙂 Review please Comments are resolved, take a look, please label Apr 11, 2024
@Alllex202 Alllex202 force-pushed the fix/condo/DOMA-8789/fix-news-items-addresses-loading branch 3 times, most recently from 34679a7 to 58e7018 Compare April 12, 2024 08:39
@Alllex202 Alllex202 force-pushed the fix/condo/DOMA-8789/fix-news-items-addresses-loading branch from 58e7018 to ed33a3c Compare April 16, 2024 11:18
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Alllex202 Alllex202 merged commit be25242 into master Apr 16, 2024
24 checks passed
@Alllex202 Alllex202 deleted the fix/condo/DOMA-8789/fix-news-items-addresses-loading branch April 16, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋🙂 Review please Comments are resolved, take a look, please
Development

Successfully merging this pull request may close these issues.

None yet

2 participants