refactor(codegen): INFRA-316 update app00 template and add backend miniapp template #4708
Conversation
nomerdvadcatpyat
added
the
🔬 WIP
nomerdvadcatpyat
changed the title
|
What about template for |
nomerdvadcatpyat
removed
the
🔬 WIP
It's out of this pr scope |
packages/codegen/templates/app00/domains/common/components/containers/BaseLayout/BaseLayout.tsx
Outdated
Show resolved
Hide resolved
packages/codegen/templates/app00/domains/common/components/containers/BaseLayout/BaseLayout.tsx
Outdated
Show resolved
Hide resolved
packages/codegen/templates/app00/domains/common/components/containers/BaseLayout/index.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| module.exports = { | ||
| CondoOIDCMiddleware, |
There was a problem hiding this comment.
may be we need some open-condo/oidc package?
There was a problem hiding this comment.
There is even a todo by @Alllex202 if Im not mistaken :-D
There was a problem hiding this comment.
There is even a todo by @Alllex202 if Im not mistaken :-D
I don't remember such a task :)
There was a problem hiding this comment.
If you decide to put this logic in a separate package, then keep in mind that each miniapp may have its own unique logic
There was a problem hiding this comment.
If you decide to put this logic in a separate package, then keep in mind that each miniapp may have its own unique logic
why would you want to have unique oidc auth logic (especially for our home-cooked miniapps?)
nomerdvadcatpyat
force-pushed
the
refactor/infra-316/update-backend-miniapp-template
branch
from
4cfe759
to
f849ef7
Compare
There was a problem hiding this comment.
Add todo to use it in all existing miniapps
There was a problem hiding this comment.
Why not bin script?
I think it's better to keep the schema generation files in the codegen package, rather than in the root bin, so that the miniaps are not dependent on the root bin. (The truth is now in the package.the json miniap runs a lot of things from the root bin)
packages/codegen/templates/app00/domains/common/constants/index.js
Outdated
Show resolved
Hide resolved
packages/codegen/templates/app01/domains/condo/utils/bots/serviceBot.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
How about putting this in a separate package?
This really does seem like repetitive logic
There was a problem hiding this comment.
I think that everything about putting the oidc in a separate package is a separate task, this task has already grown so much. Added task and pass TODO here
...ages/codegen/templates/app01/domains/condo/utils/serverSchema/generate.condo.server.utils.js
Outdated
Show resolved
Hide resolved
packages/codegen/templates/app01/domains/condo/utils/serverSchema/index.js
Outdated
Show resolved
Hide resolved
nomerdvadcatpyat
force-pushed
the
refactor/infra-316/update-backend-miniapp-template
branch
from
f849ef7
to
01ff192
Compare
|
app00template – now it's app with keystone and next (hosted by keystone), likepassminiappapp01template – it's backend-only app template. In future we need to separate frontend app from backend app for start frontend apps on newnextversionsNow for start local miniapp development, you need to:
/condoyarn createapp test-app. If you want to create keystone + next app, you need to add--type=legacy-keystone-nextflag, if you want to create only keystone app use--type=keystoneflagyarn installnode ./bin/prepare --https --filter=test-app