Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(condo):INFRA-296 logging pipeline adjustments #4756

Merged
merged 21 commits into from
Jun 7, 2024
Merged

fix(condo):INFRA-296 logging pipeline adjustments #4756

merged 21 commits into from
Jun 7, 2024

Conversation

sitozzz
Copy link
Member

@sitozzz sitozzz commented May 21, 2024 •
edited

  • pass request_id from app ingress to app headers
  • remove http logger at all
  • add log at the earliest moment of gql request (requestdidstart maybe)

@sitozzz
Copy link
Member Author

sitozzz commented May 31, 2024

I need to complete several tasks that we found while researching the current configuration

@sitozzz sitozzz marked this pull request as draft May 31, 2024 14:27
@sitozzz sitozzz force-pushed the fix/condo/INFRA-296/move-gql-response-to-last-callback branch 3 times, most recently from 2ebd0c0 to fc7d10d Compare June 5, 2024 04:46
sitozzz added 17 commits June 6, 2024 12:26
@sitozzz
fix(keystone): INFRA-296 add log for every incoming request
41a9f88
@sitozzz
fix(keystone): INFRA-296 move gql response log output to the last cal…
a6f41d6 
…lback of apollo lifecycle
@sitozzz
fix(global): INFRA-296 completely disable auto-logging
07de979
@sitozzz
fix(global): INFRA-296 pass request id from ingress to app & add test…
5e5a77d 
… logs for debug
@sitozzz
fix(condo): INFRA-296 try to pass nginx req_id to the app
a7d57f6
@sitozzz
fix(condo): INFRA-296 try to pass nginx req_id to the app
54ae7ca
@sitozzz
fix(condo): INFRA-296 try to pass nginx req_id to the app
0c6c668
@sitozzz
fix(global): INFRA-296 try to get req.id from ingress headers
add1a7b
@sitozzz
fix(global): INFRA-296 try to increase ephemeral-storage for pg review
60aeee9
@sitozzz
fix(global): INFRA-296 try to increase ephemeral-storage for pg review
ce8db31
@sitozzz
fix(global): INFRA-296 try to get req.id from ingress headers
80094c2
@sitozzz
fix(global): INFRA-296 try to get req.id from ingress headers
4d04a7b
@sitozzz
fix(global): INFRA-296 try to get req.id from ingress headers
38cb0c2
@sitozzz
fix(global): INFRA-296 try to get req.id from ingress headers
0012f12
@sitozzz
fix(global): INFRA-296 remove test logs
e01f7c2
@sitozzz
fix(global): INFRA-296 restore original app side reqId passing scenario
1026ede
@sitozzz
fix(global): INFRA-296 provide more info at gql operation timings
af009aa
@sitozzz sitozzz force-pushed the fix/condo/INFRA-296/move-gql-response-to-last-callback branch from b418f77 to af009aa Compare June 6, 2024 07:27
@sitozzz sitozzz marked this pull request as ready for review June 6, 2024 07:30
@sitozzz sitozzz merged commit 7964913 into master Jun 7, 2024
6 checks passed
@sitozzz sitozzz deleted the fix/condo/INFRA-296/move-gql-response-to-last-callback branch June 7, 2024 08:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SavelevMatthew SavelevMatthew SavelevMatthew approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sitozzz @SavelevMatthew