Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious milestones extensions #194

Closed
jpmckinney opened this issue Jan 23, 2019 · 2 comments · Fixed by #206
Closed

Mysterious milestones extensions #194

jpmckinney opened this issue Jan 23, 2019 · 2 comments · Fixed by #206

Comments

@jpmckinney
Copy link
Member

http://standard.open-contracting.org/profiles/ppp/latest/en/extensions/milestones/

Linked from http://standard.open-contracting.org/profiles/ppp/latest/en/framework/#i-10-project-approval-dates

@duncandewhurst I don't understand this page, as these milestones fields are part of core, and there is no extension to which this documentation relates.

@duncandewhurst
Copy link
Member

Most of the changes in the draft extension documented on http://standard.open-contracting.org/profiles/ppp/latest/en/extensions/milestones/ ended up being added to core as part of the 1.1 upgrade.

The changes which aren't in core (additions to the milestoneType codelist and adding a codelist for milestoneCode) are actually part of the PPP extension and are documented there, so I think this page can be removed and the link from the framework reference replaced with a link to the milestones reference in the main OCDS docs.

Alternatively, the page could be moved under the 'Schema Reference' section of the documentation, with appropriate updates to the language.

@jpmckinney
Copy link
Member Author

Okay, I went with removing the page in #206

@jpmckinney jpmckinney added this to the 1.0.0-beta2 milestone Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants