Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dominican Republic scraper #390

Closed
aguilerapy opened this issue May 29, 2020 · 3 comments · Fixed by #436
Closed

Fix Dominican Republic scraper #390

aguilerapy opened this issue May 29, 2020 · 3 comments · Fixed by #436
Assignees
@yolile
Labels
bug Something isn't working existing spider
Projects
CDS 2020-05/2021-02

Comments

@aguilerapy
Copy link
Contributor

It raises rarfile.BadRarFile: Failed the read enough data.
@aguilerapy aguilerapy added bug Something isn't working existing spider labels May 29, 2020
@jpmckinney
Copy link
Member

The files from https://www.dgcp.gob.do/estandar-mundial-ocds/ work fine manually, so I guess it is a code issue.

@jpmckinney jpmckinney added this to To do in CDS 2020-05/2021-02 via automation May 29, 2020
@yolile yolile moved this from To do to Priority [12 max] in CDS 2020-05/2021-02 Jun 23, 2020
@aguilerapy
Copy link
Contributor Author

Now raises IDNAError('Empty domain') when trying to access: "https:///http://www.dgcp.gob.do/new_dgcp/documentos/andres/JSON_DGCP_2019.rar>"

@jpmckinney
Copy link
Member

jpmckinney commented Jun 23, 2020 •
edited
Loading

Hmm, well there shouldn't be multiple protocols: https:///http://

@yolile yolile self-assigned this Jun 26, 2020
@yolile yolile moved this from Priority [12 max] to In progress [6 max] in CDS 2020-05/2021-02 Jun 26, 2020
@jpmckinney jpmckinney mentioned this issue Jun 29, 2020
Merged
CDS 2020-05/2021-02 automation moved this from In progress [6 max] to Done Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yolile yolile

Labels
bug Something isn't working existing spider
Projects
No open projects
CDS 2020-05/2021-02
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dominican_republic.py open-contracting/kingfisher-collect
3 participants
@jpmckinney @yolile @aguilerapy