New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with data that contains non numeric values in numeric fields #62

Closed

yolile opened this issue Feb 23, 2022 · 1 comment

Labels

bug

Milestone

Member

yolile commented Feb 23, 2022

E.g., when processing colombia_api (kingfisher collection_id 2579), which contains JSON like https://apiocds.colombiacompra.gov.co/apiCCE2.0/rest/release/ocid/ocds-k50g02-31496

Pelican throws:

File "/usr/src/app/contracting_process/resource_level/consistent/tender_value.py", line 75, in calculate

    if (tender_value_amount > 0 and planning_budget_amount_amount < 0) or (
TypeError: '>' not supported between instances of 'dict' and 'int'

Member

jpmckinney commented Feb 23, 2022

Can be fixed by using deep_get(..., force=int) instead of indexing directly to tender["value"], etc.

jpmckinney added the bug label

jpmckinney added this to the Priority milestone

jpmckinney mentioned this issue

Use the new deep_has and deep_get functions #75

Closed

jpmckinney closed this as completed in

b4cbb24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment