Report failures <1%

[duncandewhurst]

For example, the 'procuring entity organization reference' check reports no failures on the compiled release screen:

But clicking through to the check shows that there are actually 3 failures:

Similarly, on the field checks screen, if the failure rate is <1% the check reports 100% success.

[jpmckinney]

Related: https://gitlab.com/datlab/ocp/ocp-data-quality/-/issues/13

UI: Make clear when 0% and 100% are the result of rounding

If 2 out of 10,000 pass, a check will have "0%" pass rate. Similarly, if 9,999 out of 10,000 pass, it will have "100%" pass rate.

However, it's important for an analyst to know whether there are exceptional passes/failures.

One solution might be to use "0%" and "100%" when it is exactly 0 and 100, and to use "~0%" and "~100%" or ">0%" or "<100%" if the number is a result of rounding.

[hrubyjan]

Done

[hrubyjan]

Let me know whether it works for you or we should change it in some way

[hrubyjan]

Sorry there is one more thing I discussed with James. Too many red zeros here. The problem can't be recognized at the first glance. I'm taking the issue back :).

[jpmckinney]

The first part about >0% and <100% works for me!

[duncandewhurst]

The first part about >0% and <100% works for me!

Same here, thanks @hrubyjan!

[hrubyjan]

percantage of failures is only displayed when at least some failures exist

[jpmckinney]

Hmm, I remember sometimes getting confused when reading a table for a publisher with very few errors. It is clearer if each cell has a number. I thought we were just going to make values that were exactly zero be a very light grey.

[jpmckinney]

https://dqt.datlab.eu/resource/352

I'd expect that, when it's exactly 0%, that it's the same grey in any column, not just the middle column.

[jakubkrafka]

Well, you originally asked for "... that were exactly zero be a very light grey.":) I'm not trying to "catch you", just double-checking here, as the original idea seems to work nicely here. The zero here is just a "placeholder", to ease the UX, not to transfer any info.

[jpmckinney]

There were 3 requests:

1. Use ">0%" and "<100%" if not exactly 0 or exactly 100, because it is relevant to users to know when there are exceptional passes/failures. This was done.
2. Put a "0%" instead of an empty cell, to make the table easier to read (i.e. it is clearer that there are no passes/failures if they read "0%"). This was done.
3. Make all "0%" grey, so that it is easier to ignore them and see the more relevant non-zero values. This was only done for the failure column, for some reason?