[BB-6458] Fix tasks that create django users for IDAs #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a django user for IDA (i.e. when service name is specified), we only want to create it for that IDA, so we add a predicate that checks that service name is empty for the tasks that create django users in edxapp.
kaustavb12
reviewed
Jul 8, 2022
kaustavb12
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
👍
Approved, subject to the resolution of the review comments.
- I tested this: Verified test instance is successfully provisioned with this branch and lms users have been populated
- I read through the code
…ecified When creating a django user for edxapp and not for IDA (i.e. when service name is not specified), we don't want the tasks that create django users in IDAs to be executed, because they don't pass `lms` and/or `cms` to `manage.py`, so these tasks fail for edxapp. To fix that we add a predicate that checks that service name has been specified to these tasks, so they only run when creating a django user for an IDA.
Cup0fCoffee
force-pushed
the
maxim/bb-6458-fix-user-creation-tasks
branch
from
6929edd
to
d390511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tasks that create django users for IDAs would run when creating django users for
edx-platform. In theirmanage.pycommand they would omitlmsorcms(because they are targeting IDAs), and that would cause the tasks to fail, because when runningmanage.pycommands inedx-platform, passinglmsorcmsis mandatory.Since these tasks should only run when targeting IDAs, added a predicate, that checks that
servicevariable is not an empty string. That way these tasks will only be executed when the playbook is used to create a django user for an IDA.Links
BB-6458