DRAFT: BB-2798 LTI plugin for piazza discussions #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Discussion model Added discussions app Added model to link course and discusion Added API to access configuration options for a course Added API to access active configuration for a course
Add new discussions app to test settings
Added tests for apis and fix existing tests Fix bugs Fix docs
name should never be blank provider should be indexed and never blank configs should never be blank and should default to an empty dict
Add admin models
xitij2000
reviewed
Aug 7, 2020
xitij2000
reviewed
Aug 7, 2020
xitij2000
reviewed
Aug 7, 2020
pcockwell
force-pushed
the
patrick/BB-2798-make-basic-lti-based-plugin-for-piazza
branch
from
3132844
to
98e9d1a
Compare
xitij2000
reviewed
Aug 7, 2020
Comment on lines
+36
to
+50
| HTML( | ||
| lti_embed( | ||
| html_element_id='piazza-discussion-lti-embed', | ||
| lti_launch_url=self.LTI_LAUNCH_URL, | ||
| oauth_key=discussion_config.private_config["oauth_key"], | ||
| oauth_secret=discussion_config.private_config["oauth_secret"], | ||
| resource_link_id=resource_link_id, | ||
| user_id=user_id, | ||
| roles='Student', # TODO Use API for this when available | ||
| context_id=course_id, # TODO Use API for this when available | ||
| context_title=course.display_name_with_default, | ||
| context_label=course.display_org_with_default, | ||
| result_sourcedid=result_sourcedid | ||
| ) | ||
| ) |
There was a problem hiding this comment.
It would be nice if we could be put this in an iframe. But it's OK for testing.
Comment on lines
+1
to
+4
| # IMPORTANT: Do not import anything in this file in the top level of any | ||
| # file that is required by classes that are themselves DiscussionApps, as it | ||
| # will cause a circular import issue. Instead, import it only at the last moment | ||
|
|
There was a problem hiding this comment.
Thanks for pointing this out. I'll try to reduce these interdependencies.
| from openedx.core.djangoapps.discussions.discussions_apps import DiscussionApp | ||
|
|
There was a problem hiding this comment.
Avoid unnecessary diffs, in this case it's OK since it's just to test.
xitij2000
force-pushed
the
kshitij/discussion-plugin-api
branch
from
ff81a85
to
e22d5b4
Compare
xitij2000
force-pushed
the
kshitij/discussion-plugin-api
branch
from
e22d5b4
to
fa8e131
Compare
xitij2000
force-pushed
the
kshitij/discussion-plugin-api
branch
3 times, most recently
from
40f8a53
to
303662a
Compare
xitij2000
force-pushed
the
kshitij/discussion-plugin-api
branch
8 times, most recently
from
80be2d4
to
604d51e
Compare
xitij2000
force-pushed
the
kshitij/discussion-plugin-api
branch
2 times, most recently
from
0cc328f
to
c5e85c7
Compare
bradenmacdonald
deleted the
patrick/BB-2798-make-basic-lti-based-plugin-for-piazza
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this PR is NEVER intended to be merged. It has been created to facilitate discussion on the code while https://github.com/edx/edx-platform/pull/24584/ waits to be merged upstream. This PR builds on (and is compared directly against) https://github.com/open-craft/edx-platform/tree/kshitij/discussion-plugin-api.
** Testing Instructions **:
pip install -e .make lms-restart