Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick fix for Studio file upload issues #272

Merged

Conversation

kaizoku
Copy link

@kaizoku kaizoku commented Oct 7, 2020

This cherry picks a fix from open-release/juniper.master to fix file upload issues on the studio.

When selecting a file for uploading to the Course Card image, or the Certificate Signatory Editor view, instead of showing the file it shows "[object HTMLInputElement]", and the file upload fails. This cherry picked fix from upstream fixes the issue.

JIRA tickets: Fixes SE-3472.

Screenshots:
Without this fix after using the file selection dialog:
Screenshot_2020-10-07 Schedule Details Settings Demonstration Course Studio

Testing instructions:

  1. Attempt to change Course Card Image in the studio to test the file upload dialog
  2. Ensure that it correctly shows the path and the upload works

Reviewers

  • (@swalladge )

@mtyaka
Copy link
Member

mtyaka commented Oct 7, 2020

Thanks for this @kaizoku! 👍

  • I tested this: I applied the patch to my test Ocim instance and verified that it fixes the upload problem.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@samuelallan72 samuelallan72 merged commit 90590a2 into opencraft-release/juniper.3 Oct 8, 2020
@samuelallan72 samuelallan72 deleted the josh/SE-3472-file-uploads branch October 8, 2020 00:16
nizarmah pushed a commit that referenced this pull request Oct 18, 2020
Fix video handouts uploads.

Cherry picked from #272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants