Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default grade designations configurable from settings #541

Conversation

kaustavb12
Copy link
Member

(cherry picked from commit 7a7af8c)

cherry pick for PR#32406

@kaustavb12 kaustavb12 force-pushed the kaustav/default_grade_designations_nutmeg branch from edb22a4 to 4e93117 Compare June 11, 2023 18:21
Copy link

@keithgg keithgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM @kaustavb12

  • I read through the code
  • I checked that the diff matches the upstream PR. Except for an errant comma, it does.

@kaustavb12 kaustavb12 merged commit 9475431 into opencraft-release/nutmeg.2 Jun 12, 2023
30 checks passed
@kaustavb12 kaustavb12 deleted the kaustav/default_grade_designations_nutmeg branch June 12, 2023 08:07
xitij2000 pushed a commit that referenced this pull request Jun 27, 2023
(cherry picked from commit 7a7af8c)
(cherry picked from commit 9475431)
0x29a pushed a commit that referenced this pull request Dec 28, 2023
(cherry picked from commit 7a7af8c)
(cherry picked from commit 9475431)
(cherry picked from commit 3ca85ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants