This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
[BB-3869] Update Hero page #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunsinghy96
changed the title
farhaanbukhsh
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
👍
- I tested this: Checked on local devstack, this looks alright and changes are reflected
- I read through the code
-
I checked for accessibility issues -
Includes documentation -
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
arjunsinghy96
force-pushed
the
arjun/bb-3869-hero-page
branch
from
a729a6d
to
553fc62
Compare
farhaanbukhsh
suggested changes
Apr 15, 2021
arjunsinghy96
force-pushed
the
arjun/bb-3869-hero-page
branch
from
7025897
to
658694e
Compare
farhaanbukhsh
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
👍
- I tested this: I tested these changes with local setup
- I read through the code
-
I checked for accessibility issues -
Includes documentation -
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
Updates hero page to conform to the new UI
arjunsinghy96
force-pushed
the
arjun/bb-3869-hero-page
branch
from
658694e
to
20ef40d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates hero page to conform to the new UI
Related Tickets BB-3869 Gitlab#721
Testing Instructions
BetaTestApplicationScreenshots
Hero Edit screen