Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

fix: [BB-4143] Reused style in registration #786

Merged
merged 2 commits into from
May 9, 2021

Conversation

farhaanbukhsh
Copy link
Member

Reused the style for background image

JIRA tickets: BB-4143

Discussions: PR

Dependencies: None

Screenshots:

image

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.

Testing instructions:

  1. Get the devstack running
  2. Check http://localhost:3000/registration/domain
  3. Check the congratulation page as well

Author notes and concerns:

  1. Instead of using the same class I went with mixin approach

Reviewers

@farhaanbukhsh farhaanbukhsh requested a review from 0x29a May 4, 2021 18:01
Copy link
Member

@0x29a 0x29a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested that background is present on registration pages.
  • I read through the code.

@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/bb-4143-fix-broken-header-reuse-style branch from b112b8e to 11f40de Compare May 7, 2021 16:39
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/bb-4143-fix-broken-header-reuse-style branch from 11f40de to 1fd70f9 Compare May 8, 2021 22:38
@farhaanbukhsh farhaanbukhsh merged commit 56bb49d into master May 9, 2021
@farhaanbukhsh farhaanbukhsh deleted the farhaan/bb-4143-fix-broken-header-reuse-style branch May 9, 2021 05:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants