refactor: Apply suggestions from code review

Co-authored-by: Jillian <jill@opencraft.com>
open-craft · Jul 19, 2023 · de6fa67 · de6fa67
1 parent a0fedd3
commit de6fa67
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/openedx_tagging/core/tagging/rest_api/v1/views.py b/openedx_tagging/core/tagging/rest_api/v1/views.py
@@ -140,7 +140,11 @@ def get_object(self):
 
     def get_queryset(self):
         """
-        Return a list of taxonomies. If you want the disabled taxonomies, pass enabled=False. If you want all taxonomies (both enabled and disabled), pass enabled=None.
+        Return a list of taxonomies.
+        
+        Returns all taxonomies by default.
+        If you want the disabled taxonomies, pass enabled=False.
+        If you want the enabled taxonomies, pass enabled=True.
         """
         query_params = TaxonomyListQueryParamsSerializer(
             data=self.request.query_params.dict()

diff --git a/tests/openedx_tagging/core/tagging/test_views.py b/tests/openedx_tagging/core/tagging/test_views.py
@@ -87,7 +87,7 @@ def test_list_taxonomy(self, user_attr, expected_status):
         ("user", {"enabled": True}, status.HTTP_200_OK),
         ("user", {"enabled": False}, status.HTTP_404_NOT_FOUND),
         ("staff", {"enabled": True}, status.HTTP_200_OK),
-        ("staff", {"enabled": True}, status.HTTP_200_OK),
+        ("staff", {"enabled": False}, status.HTTP_200_OK),
     )
     @ddt.unpack
     def test_detail_taxonomy(self, user_attr, taxonomy_data, expected_status):