Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors System Taxonomy logic to use some ObjectTag subclasses #6

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Refactors System Taxonomy logic to use some ObjectTag subclasses #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
388bce8
style: linting and formatting
pomegranited Jul 19, 2023
af8910a
refactor: use negative numbers as primary keys for system taxonomies …
pomegranited Jul 19, 2023
9fd8854
refactor: use ObjectTag subclasses where possible
pomegranited Jul 19, 2023
bc2c317
refactor: LanguageTaxonomy overrides get_tags
pomegranited Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openedx_tagging/core/tagging/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,9 @@ def get_object_tags(
Pass valid_only=False when displaying tags to content authors, so they can see invalid tags too.
Invalid tags will (probably) be hidden from learners.
"""
ObjectTagClass = taxonomy.object_tag_class if taxonomy else ObjectTag
tags = (
ObjectTag.objects.filter(
ObjectTagClass.objects.filter(
object_id=object_id,
)
.select_related("tag", "taxonomy")
Expand Down
Loading
Loading