Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE-1917 Replace hacky sleeps with webdriver waits #275

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

samuelallan72
Copy link

@samuelallan72 samuelallan72 commented Apr 21, 2020

The tests don't appear to be flaky on my machine with python 3 any more, but this at least removes the hacky manual sleeps where possible. Instead it relies on webdriver waiting for changes to happen (element to exist, become visible, etc.). This will be faster and more reliable.

Test instructions:

  • sanity check the code to make sure the test semantics haven't been changed
  • verify that tests in CI reliably pass

Reviewer:

Copy link
Member

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM @swalladge !

  • I tested this by ensuring the automated tests had passed consistently.
  • I read through the code changes, and checked all the places in the tests where sleep is still invoked, to ensure there were no better options available.
  • I checked for accessibility issues test changes only
  • Includes documentation -- adds code comments where sleep was still required.
  • I made sure any change in configuration variables is reflected in the corresponding
    client's configuration-secure repository.
    N/A

@samuelallan72 samuelallan72 merged commit 3badc1c into master Apr 21, 2020
@samuelallan72 samuelallan72 deleted the samuel/fix-tests branch April 21, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants