fix: fix config comparison

open-data-plan · Apr 1, 2020 · 31fdc85 · 31fdc85
1 parent b6ebedd
commit 31fdc85
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/__tests__/plots/line.spec.tsx b/__tests__/plots/line.spec.tsx
@@ -25,7 +25,10 @@ describe('LineChart', () => {
 
     ReactDOM.render(<LineChart data={[{ x: 1 }]} forceFit />, div)
 
-    ReactDOM.render(<LineChart data={[]} forceFit={false} />, div)
+    ReactDOM.render(
+      <LineChart data={[]} forceFit xAxis={{ visible: true }} />,
+      div
+    )
 
     ReactDOM.unmountComponentAtNode(div)
   })

diff --git a/src/plots/base.tsx b/src/plots/base.tsx
@@ -51,11 +51,10 @@ export default class BaseChart<
   componentDidUpdate() {
     const config = this.getConfig(this.props)
     const { data, ...restConfig } = config as any
-    const thisFnKeys = getFnKeys(config)
-    const restFnKeys = getFnKeys(restConfig)
+    const fnKeys = getFnKeys(restConfig)
     const isConfigChanged = !isEqual(
-      omit(this.config, thisFnKeys),
-      omit(restConfig, restFnKeys)
+      omit(this.config, fnKeys),
+      omit(restConfig, fnKeys)
     )
     /* istanbul ignore else */
     if (this.chart) {