Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #71: Remove edit this page on GitHub links #72

Closed
wants to merge 1 commit into from

Conversation

jahabeebs
Copy link
Member

Closes #71

Description

  • growth team suggested removing the "edit this page on GitHub" link on each page to prevent spa,

Screenshots

Before (edit this page visible)

befroe

After

after

@jahabeebs jahabeebs self-assigned this Jan 16, 2024
@pi0neerpat
Copy link
Member

We decided not to move the edit button, because it gives people an easy route to suggest changes. I don't foresee an issue with receiving too many PR requests for editing our docs on Github. We can re-assess if that becomes an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove edit this page on GitHub links
2 participants