Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multiple pools #53

Closed
pi0neerpat opened this issue Feb 4, 2024 · 1 comment
Closed

Enable multiple pools #53

pi0neerpat opened this issue Feb 4, 2024 · 1 comment
Assignees
@jahabeebs

Comments

@pi0neerpat
Copy link
Member

Depends on #45

Now that we can load data from a single pool, we need to add the ability to pull for multiple pools.

  • Rename fetchNitroPoolODGwstETH to fetchNitroPool which is more generic
  • The arguments should accept the token symbol (eg. WSTETH), instead of the address of the pool
  • Validate that we are fetching all data needed (see both app screenshots below)

image

image
This was referenced Feb 4, 2024
Closed
Closed
@jahabeebs jahabeebs mentioned this issue Feb 6, 2024
Closed
@jahabeebs
Copy link
Member

Closing as won't do -- part of TVL project

@jahabeebs jahabeebs closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jahabeebs jahabeebs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #45: Add Camelot Nitro Pool Interface to SDK open-dollar/od-sdk
2 participants
@pi0neerpat @jahabeebs