Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P1] Ensure usage of RFC2822 or ISO date strings with moment() #52

Open
willroberts opened this issue Sep 25, 2022 · 0 comments
Open

[P1] Ensure usage of RFC2822 or ISO date strings with moment() #52

willroberts opened this issue Sep 25, 2022 · 0 comments
Labels
backend Related to server / worker code frontend Related to app / game client code help wanted Extra attention is needed security

Comments

@willroberts
Copy link
Collaborator

There is a minor vulnerability in our version of moment: https://security.snyk.io/vuln/SNYK-JS-MOMENT-2440688)

Upgrading to v2.29.2 will resolve this, but we have several date strings which don't satisfy RFC2822 or ISO formats (which raise errors in the new version).

We should update these strings and then upgrade moment.

See http://momentjs.com/guides/#/warnings/js-date/ for more info.
@willroberts willroberts added the enhancement New feature or request label Sep 25, 2022
@willroberts willroberts changed the title Ensure usage of RFC2822 or ISO date strings with moment() [APP, SERVER] Ensure usage of RFC2822 or ISO date strings with moment() Sep 25, 2022
@willroberts willroberts mentioned this issue Sep 25, 2022
Merged
@willroberts willroberts added the help wanted Extra attention is needed label Sep 26, 2022
This was referenced Sep 27, 2022
Merged
Open
@willroberts willroberts added good first issue frontend Related to app / game client code labels Oct 13, 2022
@willroberts willroberts changed the title [APP, SERVER] Ensure usage of RFC2822 or ISO date strings with moment() [SERVER] Ensure usage of RFC2822 or ISO date strings with moment() Oct 13, 2022
@willroberts willroberts added the backend Related to server / worker code label Oct 13, 2022
@willroberts willroberts changed the title [SERVER] Ensure usage of RFC2822 or ISO date strings with moment() [P1] Ensure usage of RFC2822 or ISO date strings with moment() Oct 13, 2022
@willroberts willroberts added security and removed P1 enhancement New feature or request labels Oct 13, 2022
@willroberts willroberts mentioned this issue Jan 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Related to server / worker code frontend Related to app / game client code help wanted Extra attention is needed security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@willroberts